Nativo: Add optional placementId parameter and SDK Renderer Version in response#4380
Open
rafataveira wants to merge 5 commits intoprebid:masterfrom
Open
Nativo: Add optional placementId parameter and SDK Renderer Version in response#4380rafataveira wants to merge 5 commits intoprebid:masterfrom
rafataveira wants to merge 5 commits intoprebid:masterfrom
Conversation
rafataveira
changed the title
osulzhenko
reviewed
Feb 19, 2026
src/test/groovy/org/prebid/server/functional/tests/BidderParamsSpec.groovy
Show resolved
Hide resolved
CTMBNara
requested changes
Feb 19, 2026
src/main/java/org/prebid/server/proto/openrtb/ext/request/nativo/ExtImpNativo.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/nativo/NativoBidder.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/nativo/NativoBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/nativo/NativoBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/nativo/NativoBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/nativo/NativoBidderTest.java
Outdated
Show resolved
Hide resolved
CTMBNara
requested changes
Feb 23, 2026
Comment on lines
83
to
92
| return bidResponse.getSeatbid().stream() | ||
| .filter(Objects::nonNull) | ||
| .map(seatBid -> seatBid.getBid().stream() | ||
| .filter(Objects::nonNull) | ||
| .map(bid -> updateBid(bid, rendererVersion, errors)) | ||
| .filter(Objects::nonNull) | ||
| .map(bid -> BidderBid.of(bid, BidderUtil.getBidType(bid, impMap), bidResponse.getCur())) | ||
| .toList()) | ||
| .flatMap(Collection::stream) | ||
| .toList(); |
Collaborator
There was a problem hiding this comment.
return bidResponse.getSeatbid().stream()
.filter(Objects::nonNull)
.map(SeatBid::getBid)
.filter(Objects::nonNull)
.flatMap(Collection::stream)
.filter(Objects::nonNull)
.map(bid -> updateBid(bid, rendererVersion, errors))
.map(bid -> BidderBid.of(bid, BidderUtil.getBidType(bid, impMap), bidResponse.getCur()))
.toList();
MattMur
reviewed
Feb 23, 2026
Comment on lines
129
to
134
| final ExtBidPrebidMeta updatedMeta = extBidPrebid | ||
| .map(ExtBidPrebid::getMeta) | ||
| .map(ExtBidPrebidMeta::toBuilder) | ||
| .orElseGet(ExtBidPrebidMeta::builder) | ||
| .rendererVersion(rendererVersion) | ||
| .build(); |
There was a problem hiding this comment.
@rafataveira I see we are setting the rendererVersion but where are we setting the rendererName?
Contributor
Author
There was a problem hiding this comment.
@MattMur, the rendererName is already set, as we use the name to find it in the renderers list to update the version. Line 102
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds native support for the Nativo bidder to the codebase, moving it from a generic alias-based configuration to a dedicated, fully integrated bidder module. The changes include the implementation of the Nativo bidder logic, configuration, schema, and integration tests, as well as the removal of the old alias-based approach.
Nativo Bidder Integration:
NativoBidderclass, handling bid requests and responses, bid extension updates, and error handling. (NativoBidder.java)ExtImpNativo. (ExtImpNativo.java)NativoConfiguration.java)nativo.yaml)nativo.json)Testing and Documentation:
NativoTest.java,test-auction-nativo-request.json,test-auction-nativo-response.json,test-nativo-bid-request.json,test-nativo-bid-response.json) [1] [2] [3] [4] [5]Configuration and Cleanup:
generic.yaml,test-application.properties,PbsConfig.groovy,BidderParamsSpec.groovy) [1] [2] [3] [4] [5]These changes ensure that Nativo is now a first-class, configurable bidder in the system, with dedicated code, configuration, validation, and tests.
Schema validation:
nativo.jsonto define and validate the parameters accepted by the Nativo adapter.🔧 Type of changes
✨ What's the context?
Adding optional property "placementId" to Nativo Adapter
Adding SDK Renderer Version in Response
🧠 Rationale behind the change
We have already been using this property, but it wasn't correctly documented in the adapter.
Our mobile ad formats need the Prebid Renderer name and version to work.
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
Added all the necessary tests.
🏎 Quality check